Skip to content

docs + htcondor fix#130

Merged
oshaughn merged 5 commits into
oshaughn:rift_O4dfrom
oshaughnessy-junior:rift_O4d_junior
May 11, 2026
Merged

docs + htcondor fix#130
oshaughn merged 5 commits into
oshaughn:rift_O4dfrom
oshaughnessy-junior:rift_O4d_junior

Conversation

@oshaughn
Copy link
Copy Markdown
Owner

  • htcondor2 engine: was not correctly quoting argument strings, so it broke some behavior.
  • docs: more documentation project (asimov; calmarg; 'physics') and critically the simulation_manager design page

Richard O'Shaughnessy added 5 commits May 8, 2026 21:48
The HTCondorBackend in dag_utils_generic.py was emitting

    arguments = <joined args>

with no outer quoting, putting condor_submit into its old
arguments-syntax mode.  That changed how brackets, commas, and
embedded single-quoted tokens are parsed (e.g. '[0.2,0.2499]'
reached the executable as a different argv string) relative to
the original glue.pipeline implementation, whose write_sub_file
wraps the join in double quotes (new arguments syntax).

Wrap the joined argument string in double quotes in
HTCondorBackend._build_submit_dict so both the htcondor.Submit
render path and the text fallback emit

    arguments = "<joined args>"

exactly matching glue's behavior.  Idempotent: if the caller
already wrapped the string, we don't double-wrap.  Slurm is
unaffected because the wrap lives at the HTCondor-specific seam
rather than in the shared _build_argument_string.
@oshaughn oshaughn merged commit a58eba3 into oshaughn:rift_O4d May 11, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant